C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

fix: remove memory leak `iterative_factorial.cpp`

Open vil02 opened this issue 2 years ago • 6 comments

Description of Change

There is a memory leak in iterative_factorial.cpp while throwing an exception. This PR fixes it and does some other small changes.

Checklist

  • [x] Added description of change
  • [x] ~Added file name matches File name guidelines~
  • [x] ~Added tests and example, test must pass~
  • [x] ~Added documentation so that the program is self-explanatory and educational - Doxygen guidelines~
  • [x] ~Relevant documentation/comments is changed or added~
  • [x] PR title follows semantic commit guidelines
  • [x] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [x] I acknowledge that all my contributions will be made under the project's license.

Notes: Removes memory leak in iterative_factorial.cpp.

vil02 avatar Sep 18 '23 16:09 vil02

@vil02, some suggestions.. pls resolve the conflits

image

CarlosZoft avatar Oct 02 '23 11:10 CarlosZoft

@vil02, some suggestions.. pls resolve the conflits

image

@CarlosZoft luckily there were no conflicts, just my branch was out-of-date. It is fixed now.

vil02 avatar Oct 02 '23 11:10 vil02

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 24 '23 00:12 github-actions[bot]

@Panquesito7, @realstealthninja: Merry Christmas and please dont-close.

vil02 avatar Dec 24 '23 04:12 vil02

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 11 '24 00:04 github-actions[bot]

Please add dont-close or merge.

vil02 avatar Apr 11 '24 06:04 vil02