C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

[FEATURE] Add self-tests in `greedy_algorithms/kruskals_minimum_spanning_tree.cpp`

Open Panquesito7 opened this issue 1 year ago • 8 comments

Detailed description

The algorithm was documented in #2482, however, it is still missing self-test implementations that make sure the algorithm works as expected, which will make the algorithm fully up to our guidelines.

Context

This is very much needed as without self-tests, it cannot be proved whether the algorithm gives the correct output.

Possible implementation

No response

Additional information

No response

Panquesito7 avatar Jul 21 '23 18:07 Panquesito7

i have code ready with all the required changes. can you assign it to me.

sorohere avatar Jul 24 '23 13:07 sorohere

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 25 '23 00:08 github-actions[bot]

Yes I would like to contribute to this issue along with adding code for the algorithm in very documented way. Please assign it to me.

avnis838 avatar Sep 27 '23 19:09 avnis838

@sOR-o can you give an update on this?

realstealthninja avatar Nov 11 '23 14:11 realstealthninja

Ya i have done but, my mid semester are near so i will be free from 28 of Nov.

On Sat, Nov 11, 2023 at 8:07 PM realstealthninja @.***> wrote:

@sOR-o https://github.com/sOR-o can you give an update on this?

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/C-Plus-Plus/issues/2509#issuecomment-1806833075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVALUHSLH2FUDNT6IPFK5PTYD6ERJAVCNFSM6AAAAAA2TF7WB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHAZTGMBXGU . You are receiving this because you commented.Message ID: @.***>

avnis838 avatar Nov 11 '23 16:11 avnis838

I have some more to add, that i will then.

On Sat, Nov 11, 2023 at 10:05 PM AVNISH KUMAR @.***> wrote:

Ya i have done but, my mid semester are near so i will be free from 28 of Nov.

On Sat, Nov 11, 2023 at 8:07 PM realstealthninja @.***> wrote:

@sOR-o https://github.com/sOR-o can you give an update on this?

— Reply to this email directly, view it on GitHub https://github.com/TheAlgorithms/C-Plus-Plus/issues/2509#issuecomment-1806833075, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVALUHSLH2FUDNT6IPFK5PTYD6ERJAVCNFSM6AAAAAA2TF7WB2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHAZTGMBXGU . You are receiving this because you commented.Message ID: @.***>

avnis838 avatar Nov 11 '23 16:11 avnis838

Hi @reviewer,

I have implemented the solution for adding self-tests in greedy_algorithms/kruskals_minimum_spanning_tree.cpp as discussed in issue #2509. The pull request (#2707) includes all the necessary changes and has been tested to ensure it meets the requirements.

Please review the changes and let me know if there are any adjustments needed. If everything looks good, could you please merge this pull request?

Thank you!

Meetmendapara09 avatar Aug 10 '24 05:08 Meetmendapara09