C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

[FEATURE] Create a pull request for the Clang Tidy

Open Panquesito7 opened this issue 2 years ago • 3 comments

Detailed description

Currently, all of the Clang Tidy changes are being pushed in forks and appearing in other pull requests. However, these changes are not being pushed to the original repository due to the main branch being protected. This can be fixed by creating a pull request (running the action only on this repository) and then the maintainers merging the PR to reflect the changes.

Context

This will make it better for both PR creators and reviewers.

  • PR creators won't have unwanted changes in their PRs.
  • Reviewers won't be confused about other changes in PRs.
  • All changes will be pushed to the original repository, and all missed things will be fixed.

Possible implementation

Create a pull request instead of committing directly.

Additional information

We could also make the check fail if the user has missed anything and let the user fix the errors themselves. It depends on what you like most. Having a PR created makes it easier and faster. Having the user fix the errors themselves helps them learn.

Let me know your thoughts.

Panquesito7 avatar Jun 23 '23 20:06 Panquesito7

this seems like a good idea

realstealthninja avatar Jun 24 '23 05:06 realstealthninja

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 04 '23 00:08 github-actions[bot]

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

github-actions[bot] avatar Aug 12 '23 00:08 github-actions[bot]