C-Plus-Plus icon indicating copy to clipboard operation
C-Plus-Plus copied to clipboard

feat: added indexed priority queues

Open ron0studios opened this issue 2 years ago • 6 comments

also added tests for the implementation. See the file for more details

Description of Change

Checklist

  • [x] Added description of change
  • [x] Added file name matches File name guidelines
  • [x] Added tests and example, test must pass
  • [x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • [x] Relevant documentation/comments is changed or added
  • [x] PR title follows semantic commit guidelines
  • [x] Search previous suggestions before making a new one, as yours may be a duplicate.
  • [x] I acknowledge that all my contributions will be made under the project's license.

Notes:

Im not sure whether I should rename the filename as something like queue-priority-index instead of indexed-priority-queue for the sake of file grouping.

ron0studios avatar Oct 06 '22 21:10 ron0studios

Just made the relevant changes, thanks!

ron0studios avatar Oct 07 '22 05:10 ron0studios

Is there anything else I need to add @Panquesito7 ?

ron0studios avatar Oct 08 '22 16:10 ron0studios

Sorry, @Panquesito7 did I miss anything out? For some reason it still says that there are changes requested even though they've been resolved? Thanks,

ron0studios avatar Oct 09 '22 19:10 ron0studios

@Panquesito7 Could you do another review please? It's been a couple of days and I've made the relevant changes. If there is anything that needs adding, please do let me know! Thank you

ron0studios avatar Oct 13 '22 16:10 ron0studios

please @Panquesito7 could you review this, or anyone else, if possible? Sorry if I'm coming off as impatient, I would just like some forewarning as to how long the process will atleast take. Thank you!

ron0studios avatar Oct 18 '22 14:10 ron0studios

@Panquesito7 the clang tidy errors should also be resolved i think!

ron0studios avatar Oct 22 '22 10:10 ron0studios

the changes have been resolved i think. is there anything else i need to add?

ron0studios avatar Nov 05 '22 09:11 ron0studios

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Feb 26 '23 00:02 github-actions[bot]

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

github-actions[bot] avatar Mar 05 '23 00:03 github-actions[bot]