C-Plus-Plus
C-Plus-Plus copied to clipboard
feat: binary exponentiation
Description of Change
Added binary exponentiation algorithm
Checklist
- [x] Added description of change
- [x] Added file name matches File name guidelines
- [x] Added tests and example, test must pass
- [x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
- [x] PR title follows semantic commit guidelines
- [x] Search previous suggestions before making a new one, as yours may be a duplicate.
- [x] I acknowledge that all my contributions will be made under the project's license.
Notes: added binary exponentiation
fixes #1734
A question: is the same algorithm as this algorithm?
If so, we might have to rename this to binary_exponentiation2.cpp
.
My bad. It seems that is the case. Didn't check that directory as issue #1734 mentions it under divide and conquer. Does this mean either of the two algorithms have to move to another directory?
My bad. It seems that is the case. Didn't check that directory as issue #1734 mentions it under divide and conquer. Does this mean either of the two algorithms have to move to another directory?
No, it's totally fine as-is 😄 Let us rename this file to binary_exponentiation2.cpp
.
Renamed it!
Hmm, no idea why it's failing. Any ideas?
Okay, I found the issue here Okay, I found the error here https://github.com/TheAlgorithms/C-Plus-Plus/runs/4096578335?check_suite_focus=true#step:4:250 could you please fix it? Let us know if you need any help! Thanks. slightly_smiling_face
I don't thing that's the issue. It points to a warning but it actually compiles to an executable afterwards, so that couldn't be the issue.
Okay, I found the issue here Okay, I found the error here https://github.com/TheAlgorithms/C-Plus-Plus/runs/4096578335?check_suite_focus=true#step:4:250 could you please fix it? Let us know if you need any help! Thanks. slightly_smiling_face
I don't thing that's the issue. It points to a warning but it actually compiles to an executable afterwards, so that couldn't be the issue.
It is more of a warning, not an error, I think. But there could be a loss of data there, so please try to investigate. 🙂
This branch has conflicts that must be resolved.
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!