mpv_thumbnail_script icon indicating copy to clipboard operation
mpv_thumbnail_script copied to clipboard

Doesn't work but I found the solution!

Open sdsaati opened this issue 4 years ago • 11 comments

Line 525 of mpv_thumbnail_script_server.lua, should be ("--o=%s"):format(output_path) instead of "--o", output_path, because recently if you don't do it, you will get this error:

[ 0.004][f][cplayer] Error parsing commandline option o: option requires parameter

sdsaati avatar May 26 '20 03:05 sdsaati

Thanks

ManuLinares avatar Jul 03 '20 07:07 ManuLinares

This fixed it for me! It seems a (different) (also working for me) fix is already in the source code in master branch, but not in the releases page linked in the README.

InigoGutierrez avatar Jul 15 '20 22:07 InigoGutierrez

Works with mpv, but not mpv.net.

turmoggy avatar Jul 27 '20 17:07 turmoggy

thanks

eyirkce avatar Aug 20 '20 09:08 eyirkce

your welcome :)

sdsaati avatar Sep 05 '20 19:09 sdsaati

Now if only that cure would find its way back into the release...

(It's still giving this error as of November 11, 2020).

emk2203 avatar Nov 11 '20 10:11 emk2203

@emk2203, Hi, can you please give me the exact error you get?

sdsaati avatar Nov 11 '20 11:11 sdsaati

How about close this issue?

This problem occurs because downloading the legacy script mpv_thumbnail_script_server.lua from https://github.com/TheAMM/mpv_thumbnail_script/releases lastest released from "Feb 8, 2018".

This was fixed at commit 682becf5b5115c2a206b4f0bdee413d4be8b5bef at "Jan 17, 2020".

Steps to get the lastest mpv_thumbnail_script_server.lua and mpv_thumbnail_script_client_osc.lua:

$ git clone https://github.com/TheAMM/mpv_thumbnail_script
$ cd mpv_thumbnail_script
$ make
./concat_files.py -r cat_server.json
Concatenated source files to 'mpv_thumbnail_script_server.lua'
./concat_files.py -r cat_osc.json
Concatenated source files to 'mpv_thumbnail_script_client_osc.lua'

snowman avatar Mar 04 '21 05:03 snowman

How about close this issue?

This problem occurs because downloading the legacy script mpv_thumbnail_script_server.lua from https://github.com/TheAMM/mpv_thumbnail_script/releases lastest released from "Feb 8, 2018".

This was fixed at commit 682becf at "Jan 17, 2020".

Steps to get the lastest mpv_thumbnail_script_server.lua and mpv_thumbnail_script_client_osc.lua:

$ git clone https://github.com/TheAMM/mpv_thumbnail_script
$ cd mpv_thumbnail_script
$ make
./concat_files.py -r cat_server.json
Concatenated source files to 'mpv_thumbnail_script_server.lua'
./concat_files.py -r cat_osc.json
Concatenated source files to 'mpv_thumbnail_script_client_osc.lua'

Why not create a new release?

kimabjorkede avatar Mar 31 '21 19:03 kimabjorkede

I'm another fool who downloaded from releases... please update the release, thanks.

ronilaukkarinen avatar Jul 05 '21 20:07 ronilaukkarinen

not working for me

ghost avatar Jun 23 '22 19:06 ghost