mpv_thumbnail_script icon indicating copy to clipboard operation
mpv_thumbnail_script copied to clipboard

Published 20 hours ago • verified publisher icon TheAMM

Try to guard against nil properties.

Open tonycpsu opened this issue 5 years ago • 3 comments

There seems to be a race condition (see #19) when a file is loaded where some properties are set and then later read as nil. This attempts to fix this by saving non-nil properties to the global state and reading from that. Seems to eliminate the problem so far.

tonycpsu avatar Nov 28 '19 05:11 tonycpsu

Eh, I don't think this is a full fix just yet. The issues with video-dec-params and path have gone away, but I think it just pushes the race condition problem elsewhere in the code. Now I get things like: Lua error: ...nyc/.mpv/scripts/mpv_thumbnail_script_client_osc.lua:890: bad argument #1 to 'max' (number expected, got nil). Getting errors far less often, but still getting them. @TheAMM , do you have any pointers on where to look for the problem?

tonycpsu avatar Nov 30 '19 02:11 tonycpsu

i have similar problem maybe related to this issue [mpv_thumbnail_script_client_osc] Lua error: .../.config/mpv/scriptsmpv_thumbnail_script_client_osc.lua:1080: attempt to compare nil with number more info mentioned here these are my logs is there some correlation ?

picarica avatar Feb 07 '20 15:02 picarica

@tonycpsu Do all of the problems you encounter happen shortly after changing videos?

#54 Should fix these issues.

blankname avatar Mar 04 '20 20:03 blankname