mpv_thumbnail_script icon indicating copy to clipboard operation
mpv_thumbnail_script copied to clipboard

Fix grammar and future-proof against new releases

Open soulofmischief opened this issue 6 years ago • 6 comments

There was a grammatical redundancy in the phrase "both the two", so by generalizing the statement to any arbitrary number of .lua files we simultaneously fix this redundancy and future-proof the README against new releases, which might add or subtract a script file.

soulofmischief avatar Mar 16 '19 05:03 soulofmischief

Not sure if trolling...

Hrxn avatar Mar 16 '19 05:03 Hrxn

Why would I be trolling? I plan to submit a few PRs and this was the lowest hanging fruit. Documentation improvements, however trivial, should be welcome.

soulofmischief avatar Mar 16 '19 14:03 soulofmischief

It's ultimately not my decision, but improvements are generally welcome, I'm sure. But things like second-person reference (2nd commit), I mean, that is not even wrong. Purely stylistic change.

Hrxn avatar Mar 16 '19 15:03 Hrxn

Sure, but that wasn't the point or title of my commit. I simply improved upon the original commit before it was accepted. If I had done that beforehand without making two separate commits, you wouldn't have said anything.

You're nitpicking and it's unwelcome, particularly because you're right, it's not your decision at all and you should let the project maintainers make their decision without comments from the peanut gallery.

soulofmischief avatar Mar 16 '19 16:03 soulofmischief

Hey buddy, that contrib graph won't get greener by its own, ok? Gimme a break here willya?

garoto avatar Mar 16 '19 16:03 garoto

@garoto Are you trying to insinuate something or am I misunderstanding?

soulofmischief avatar Mar 16 '19 16:03 soulofmischief