alpha-release icon indicating copy to clipboard operation
alpha-release copied to clipboard

Add license information and other details for flow/designs/src/*

Open asb opened this issue 5 years ago • 3 comments

It would be great to add more info to flow/designs/src/*. At a minimum - ideally a link to the upstream project, the commit hash used to produce the .v, and ideally more info about how it was generated (e.g. what options were used). You should also import a copy of any license text and other attribution information, as most open source licenses require this.

[Really pleased to see you using Ibex as a benchmark for OpenROAD by the way - and looking forward to finding time to give the flow a go].

asb avatar Aug 08 '19 14:08 asb

Thanks for the feedback. I'll try to add this. Some designs needed to be "elaborated" using a different tool because Yosys doesn't currenty support system verilog so we may not be able to have it in it's original form.

But we should be able to provide trace-ability, license and information to how the verilog sources files were generated.

tajayi avatar Aug 08 '19 15:08 tajayi

I've started going through some of the designs and adding the requested information. I've done so for ibex. Let me know if this looks good.

tajayi avatar Aug 09 '19 00:08 tajayi

Information on commit hash, how it was produced etc is a huge improvement - thanks! I'm not a lawyer, but including the original license also seems like a big step forward there. Thanks for such a rapid turnaround.

asb avatar Aug 09 '19 04:08 asb