Test orfs gcd eqy fixes

[oharboe]

Better:

bazelisk test //test/orfs/gcd:eqy_tests --keep_going --test_output=all

[deleted]
//test/orfs/gcd:eqy_source_test                                 (cached) PASSED in 162.7s
//test/orfs/gcd:eqy_cts_test                                             PASSED in 77.2s
//test/orfs/gcd:eqy_final_test                                           PASSED in 63.4s
//test/orfs/gcd:eqy_floorplan_test                                       PASSED in 46.6s
//test/orfs/gcd:eqy_grt_test                                             PASSED in 77.4s
//test/orfs/gcd:eqy_place_test                                           PASSED in 51.1s
//test/orfs/gcd:eqy_route_test                                           PASSED in 66.7s
//test/orfs/gcd:eqy_synth_test                                           FAILED in 13.3s
  /home/oyvind/.cache/bazel/_bazel_oyvind/896cc02f64446168f604c13ad7b60f8b/execroot/_main/bazel-out/k8-fastbuild/testlogs/test/orfs/gcd/eqy_synth_test/test.log

Executed 7 out of 8 tests: 7 tests pass and 1 fails locally.

This test still fails:

bazelisk test //test/orfs/gcd:eqy_synth_test --keep_going --test_output=streamed

EQY 21:39:04 [eqy_synth_test] run: make: Leaving directory '/home/oyvind/.cache/bazel/_bazel_oyvind/896cc02f64446168f604c13ad7b60f8b/sandbox/linux-sandbox/4662/execroot/_main/bazel-out/k8-fastbuild/bin/test/orfs/gcd/eqy_synth_test.run.sh.runfiles/_main/eqy_synth_test'
EQY 21:39:04 [eqy_synth_test] run: finished (returncode=0)
EQY 21:39:04 [eqy_synth_test] Warning: Failed to prove equivalence for 18/18 partitions:
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_val
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.15
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.14
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.13
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.12
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.11
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.10
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.9
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.8
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.7
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.6
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.5
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.4
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.3
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.2
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.1
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.resp_msg.0
EQY 21:39:04 [eqy_synth_test] Failed to prove equivalence of partition gcd.req_rdy
EQY 21:39:04 [eqy_synth_test] summary: Elapsed clock time [H:MM:SS (secs)]: 0:00:07 (7)
EQY 21:39:04 [eqy_synth_test] summary: Elapsed process time [H:MM:SS (secs)]: 0:00:09 (9)
EQY 21:39:04 [eqy_synth_test] DONE (FAIL, rc=2)
Copying 1334 files to bazel-testlogs/test/orfs/gcd/eqy_synth_test/test.outputs for inspection.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

are you proposing this to be merged or as a test case for an issue?

[oharboe]

are you proposing this to be merged or as a test case for an issue?

proposing to be merged for further collaboration and testing of eqy w openroad.

We must walk before we can run: first get the eqy LEC flow running and evaluated, then try it on something more substantial.

please review eqy test results on gcd first and then later we can examine how it fares on mock array.

eqy have previously successfully identified half adder bugs in yosys for multiplication that have been fixed in yosys.

There is currently an eqy failure going from source to synthesis on gcd that merits further study.

the negative results on gcd on floorplan through final are encouraging and I think real, but could do with a manual inspection and evaluation.

[maliberty]

Then you need to fix the test failures.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[oharboe]

Then you need to fix the test failures.

Should be fixed, I think the latest ORFS image is corrupt, reverted. Will reexamine on next ORFS if it persists.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[oharboe]

@vvbandeira @maliberty some unrelated to bazel failure it seems:

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[oharboe]

@maliberty All green now! 👍

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[oharboe]

@maliberty refactored to move shared code to shared folders between. If the computer says yes, this is good to go for my part.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[oharboe]

@maliberty unrelated CI outage I have seen in the last couple of days...

[maliberty]

You can see that it failed and retried and passed:

The real failure is in bazel https://jenkins.openroad.tools/job/OpenROAD-Public/job/PR-9012-merge/10/pipeline-overview/log?nodeId=335

[oharboe]

Just download problems it seems.