dpl: fix PQ_entry to > & == to a total order for determinism
Enable all tests bzl
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@maliberty This is where you had to manually tweak test/orfs/gcd/rules.json after run update?
@maliberty This is where you had to manually tweak test/orfs/gcd/rules.json after run update?
yes
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Master doesn't have this problem https://github.com/The-OpenROAD-Project/OpenROAD/pull/8660
Is this what you see?
$ bazelisk run test/orfs/gcd:gcd_update
$ git diff
diff --git a/test/orfs/gcd/rules-base.json b/test/orfs/gcd/rules-base.json
index 6b9d76b18c..56fad9e113 100644
--- a/test/orfs/gcd/rules-base.json
+++ b/test/orfs/gcd/rules-base.json
@@ -56,7 +56,7 @@
"compare": "<="
},
"finish__timing__drv__setup_violation_count": {
- "value": 35,
+ "value": 22,
"compare": "<="
},
"finish__timing__drv__hold_violation_count": {
@@ -67,4 +67,4 @@
"value": -27.94,
"compare": ">="
}
-}
+}
\ No newline at end of file
bazelisk test test/orfs/gcd:gcd_test --test_output=errors
[deleted]
[INFO] finish__design__instance__area pass test: 49.295 <= 57.0
[ERROR] finish__timing__drv__setup_violation_count fail test: 32.0 <= 22.0
[deleted]
@maliberty I think ORFS updates rules.json code? https://github.com/The-OpenROAD-Project/OpenROAD/pull/8661
I just had to re-run it after updating and it seemed to work ¯_(ツ)_/¯
clang-tidy review says "All clean, LGTM! :+1:"