OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

dpl: fix PQ_entry to > & == to a total order for determinism

Open openroad-ci opened this issue 2 months ago • 12 comments

Enable all tests bzl

openroad-ci avatar Oct 11 '25 00:10 openroad-ci

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 11 '25 01:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 11 '25 01:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 11 '25 03:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 11 '25 04:10 github-actions[bot]

@maliberty This is where you had to manually tweak test/orfs/gcd/rules.json after run update?

oharboe avatar Oct 11 '25 06:10 oharboe

@maliberty This is where you had to manually tweak test/orfs/gcd/rules.json after run update?

yes

maliberty avatar Oct 11 '25 15:10 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 11 '25 22:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 13 '25 16:10 github-actions[bot]

Master doesn't have this problem https://github.com/The-OpenROAD-Project/OpenROAD/pull/8660

Is this what you see?

$ bazelisk run test/orfs/gcd:gcd_update
$ git diff
diff --git a/test/orfs/gcd/rules-base.json b/test/orfs/gcd/rules-base.json
index 6b9d76b18c..56fad9e113 100644
--- a/test/orfs/gcd/rules-base.json
+++ b/test/orfs/gcd/rules-base.json
@@ -56,7 +56,7 @@
         "compare": "<="
     },
     "finish__timing__drv__setup_violation_count": {
-        "value": 35,
+        "value": 22,
         "compare": "<="
     },
     "finish__timing__drv__hold_violation_count": {
@@ -67,4 +67,4 @@
         "value": -27.94,
         "compare": ">="
     }
-}
+}
\ No newline at end of file
bazelisk test test/orfs/gcd:gcd_test --test_output=errors
[deleted]
[INFO] finish__design__instance__area pass test: 49.295 <= 57.0
[ERROR] finish__timing__drv__setup_violation_count fail test: 32.0 <= 22.0
[deleted]

oharboe avatar Oct 16 '25 06:10 oharboe

@maliberty I think ORFS updates rules.json code? https://github.com/The-OpenROAD-Project/OpenROAD/pull/8661

oharboe avatar Oct 16 '25 08:10 oharboe

I just had to re-run it after updating and it seemed to work ¯_(ツ)_/¯

maliberty avatar Oct 16 '25 20:10 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 16 '25 21:10 github-actions[bot]