OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Remove use of `popen` for gzip file reading and writing

Open gadfort opened this issue 6 months ago • 5 comments

Description

I happened upon the spef writing code and noticed it uses a popen to write the SPEF file (also for reading).

https://github.com/The-OpenROAD-Project/OpenROAD/blob/6e29df0746191b48963a35bf45422d76e2c9922c/src/rcx/src/extSpef.cpp#L1216 https://github.com/The-OpenROAD-Project/OpenROAD/blob/6e29df0746191b48963a35bf45422d76e2c9922c/src/rcx/src/parse.cpp#L140 https://github.com/The-OpenROAD-Project/OpenROAD/blob/6e29df0746191b48963a35bf45422d76e2c9922c/src/rcx/src/parse.cpp#L156

Suggested Solution

Don't call external programs to handle IO

Additional Context

No response

gadfort avatar Jun 15 '25 14:06 gadfort

@gadfort are you planning to tackle this one too?

maliberty avatar Jun 15 '25 15:06 maliberty

@maliberty I can take a look, but it's not code I've spent much time actually looking at (the writing seems straight forward-ish).

gadfort avatar Jun 15 '25 15:06 gadfort

Thanks - nobody has spent too much time with it...

maliberty avatar Jun 15 '25 18:06 maliberty

@maliberty I take back what I said about straightforward... I'll see what can be done

gadfort avatar Jun 15 '25 19:06 gadfort

Little in RCX is straightforward

maliberty avatar Jun 15 '25 19:06 maliberty