colors: tweak default colors to work better on black background
Made some darker colors brighter and easier to see. A side-by-side review of all the colors needs to be done, I don't know exactly where to find them in the GUI though.
Before:
After:
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
@oharboe it might be nice to have a side by side of all the color changes you are proposing
@oharboe it might be nice to have a side by side of all the color changes you are proposing
Yes, but to do that, I would need to know how to create side-by-side screenshots of each color in that table, which I don't...
I think we should hold off on this PR until we have such a side-by-side comparison.
It is a bit tricky, because it requires showing each color in one or more use-cases.
Just brightening it will make it confusing with metal2
Will have a look. Is that the only conflict?
How were these colors derived? Please make a before and after comparison images.
How were these colors derived? Please make a before and after comparison images.
I'm going to revert all color changes but the one that is most problematic. The others looked a bit darker to me too, but it is a bridge to far. The problem is to create lots of easy on the eye high contrast colors... Which is enormously tricky. :-)
Instead of changing multiple colors, I've changed only metal 5 and tried to introduce an additional different base color, bright orange, that works on black background.
Before:
After:
I'm going to try on more monitors, but on one either was OK, on my laptop the new scheme was definitely better.
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
Attempting to keep the color similar with higher contract with the adjacent layers: QColor(222, 33, 96)
This preserves the relative contract between M4 / M6 and increases the contrast with the background (although not as much as the orange).
Thanks! Will try on some more monitors.
@gadfort Used your proposed color. Works better on the monitors I tried. :+1:
clang-tidy review says "All clean, LGTM! :+1:"