OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

colors: tweak default colors to work better on black background

Open oharboe opened this issue 1 year ago • 17 comments

Made some darker colors brighter and easier to see. A side-by-side review of all the colors needs to be done, I don't know exactly where to find them in the GUI though.

Before:

image

After:

image

oharboe avatar Oct 18 '24 09:10 oharboe

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 18 '24 09:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 18 '24 10:10 github-actions[bot]

@oharboe it might be nice to have a side by side of all the color changes you are proposing

gadfort avatar Oct 18 '24 12:10 gadfort

@oharboe it might be nice to have a side by side of all the color changes you are proposing

Yes, but to do that, I would need to know how to create side-by-side screenshots of each color in that table, which I don't...

I think we should hold off on this PR until we have such a side-by-side comparison.

It is a bit tricky, because it requires showing each color in one or more use-cases.

oharboe avatar Oct 18 '24 12:10 oharboe

Just brightening it will make it confusing with metal2

maliberty avatar Oct 18 '24 19:10 maliberty

Will have a look. Is that the only conflict?

oharboe avatar Oct 18 '24 20:10 oharboe

How were these colors derived? Please make a before and after comparison images.

maliberty avatar Oct 19 '24 02:10 maliberty

How were these colors derived? Please make a before and after comparison images.

I'm going to revert all color changes but the one that is most problematic. The others looked a bit darker to me too, but it is a bridge to far. The problem is to create lots of easy on the eye high contrast colors... Which is enormously tricky. :-)

oharboe avatar Oct 19 '24 07:10 oharboe

Instead of changing multiple colors, I've changed only metal 5 and tried to introduce an additional different base color, bright orange, that works on black background.

Before:

image

After:

image

oharboe avatar Oct 19 '24 09:10 oharboe

I'm going to try on more monitors, but on one either was OK, on my laptop the new scheme was definitely better.

oharboe avatar Oct 19 '24 09:10 oharboe

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 19 '24 09:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 19 '24 11:10 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 19 '24 11:10 github-actions[bot]

Attempting to keep the color similar with higher contract with the adjacent layers: QColor(222, 33, 96)

image

This preserves the relative contract between M4 / M6 and increases the contrast with the background (although not as much as the orange).

gadfort avatar Oct 19 '24 14:10 gadfort

Thanks! Will try on some more monitors.

oharboe avatar Oct 19 '24 14:10 oharboe

@gadfort Used your proposed color. Works better on the monitors I tried. :+1:

oharboe avatar Oct 20 '24 17:10 oharboe

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 20 '24 17:10 github-actions[bot]