The-OpenROAD-Project
drt: genPatterns_commit refactoring
Some refactoring on genPatterns_commit is being done to improve readability and reduce code.
Access Patterns Graph Backwards Path Function and Readability
The first part of genPatterns_commit is a loop that traces a path through access points of an instance that represent a chosen access pattern.
Right now the loop is a little over complicated for what it does, so I refactored it a bit to make more obvious.
Added the variables source_node_idx and drain_node_idx to make the start and end points of the path search more clear, instead decreasing pin_cnt.
This was transformed in a function called extractAccessPatternFromNodes as it has a pretty distinct role and function.
Used Pattern Guard
The later part of the had an if statement to check is the generated pattern was unused, if true it did more checks, later it essentially had an else with return false. This as transformed into a guard.
No further changes on this function will be done in this PR as the git diff shows everything past the guard as changed due to the indentation level change. Further changes will be at a separate PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@bnmfw I see various questions that need a response.
I did not resolve some old conversations but had addressed them in the commit after them. The new reviews are new, after I told you I was waiting for this I asked for a new look up on the PR so I can merge it