The-OpenROAD-Project
gui: Add find by name to CTS viewer
Closes #5463.
Changes:
- Makes the find dialog search instances in the CTS Viewer. (Implements #5463)
- Find dialog focuses on the find text box when the popup opens
If instances are found, the CTS Viewer zooms to fit all found objects. When the design has multiple clock signals, the current tree changes to where the instances are found.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@LucasYuki FYI you can use the special keywords in GH to link a PR to an issue(s), that way when the PR gets merged, the issue will be closed. This needs to be done in the PR description.
What is the thinking behind the option find_in_cts? In what scenarios do we not want to find in cts? The select command doesn't expose the option in tcl from what I see. The inspector always passes true for instances.
@maliberty, the way it is implemented now it isn't possible to search nets in the Clock Tree Viewer, so when searching for nets we don't need to emit the findInCts signal.
I can remove this flag from the Gui::select and always pass as true the argument find_in_cts to the slot MainWindow::addSelected, but since the MainWindow::addSelected slot is responsible for emitting the findInCts signal and is called elsewhere, the flag is necessary on this slot.
Another alternative is to implement a checkbox in the find dialog, something like "Find the Clock Tree Viewer" to enable the search, so the user can choose to use or not this feature.
We don't have such an option for find and the other displays (layout, inspector). @precisionmoon - you originally asked for this feature - do you need to have a find but not in CTS option?
We don't have such an option for find and the other displays (layout, inspector). @precisionmoon - you originally asked for this feature - do you need to have a find but not in CTS option?
Sorry for the delayed response. No, we don't want an option to enable/disable search. Let's enable search all the time.
