OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

grt/rsz: write spef for estimated parasitics

Open joaomai opened this issue 1 year ago • 6 comments

Fixes https://github.com/The-OpenROAD-Project/OpenROAD/issues/4441.

Added as an option to the estimate_parasitics command, using -spef_file to pass the file path as an argument, writing one or more files based on how many corners there are. The information is written to the file during estimation, writing the net data before RC reduction is performed.

I'm unsure about the units in the header, using the same ones from the rcx header currently.

joaomai avatar Aug 26 '24 17:08 joaomai

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Aug 26 '24 18:08 github-actions[bot]

Not sure I'm fond of -spef as a flag to estimate_parasitics. Couldn't this instead use the existing API by doing write_spef after estimate_parasitics? You could print a message during write_spef indicating what kind of parasitics it's writing (global vs. detailed).

rovinski avatar Aug 26 '24 21:08 rovinski

sta reduces the parasitics so you can't write them afterwards except in reduced form which isn't that helpful.

maliberty avatar Aug 26 '24 21:08 maliberty

But could you, e.g., just add a Tcl hook or a SWIG hook which determines which function to call? Or are you saying that to write the SPEF without reduced parasitics then it has to be written out immediately?

rovinski avatar Aug 26 '24 21:08 rovinski

Yes they have to be written immediately as the unreduced form is not stored anywhere. Storing it would be quite expensive on the off change someone wants to write them out.

maliberty avatar Aug 26 '24 21:08 maliberty

That's fair then.

rovinski avatar Aug 26 '24 21:08 rovinski

@joaomai there is some feedback that still needs addressing before this can be merged.

maliberty avatar Sep 05 '24 15:09 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 06 '24 11:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 06 '24 12:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 06 '24 12:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 09 '24 19:09 github-actions[bot]

@maliberty Any more comments? I believe we need your approval to merge this PR.

eder-matheus avatar Sep 10 '24 01:09 eder-matheus

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 11 '24 01:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 11 '24 15:09 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Sep 11 '24 15:09 github-actions[bot]

Great work!

donn avatar Sep 11 '24 16:09 donn