OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Add find by name to CTS viewer

Open maliberty opened this issue 1 year ago • 7 comments

Description

To track:

From @precisionmoon We want to find a register by name in the main GUI and see the matching sink in the clock tree viewer.

Suggested Solution

From @gadfort It should be fairly easy to implement since you can piggy-back on the inspect connection to emit a second call to a sink in the viewer that can highlight it.

Additional Context

No response

maliberty avatar Jul 27 '24 00:07 maliberty

@gadfort do you want to tackle this or should I pass to @AcKoucher ?

maliberty avatar Jul 27 '24 00:07 maliberty

@maliberty if @AcKoucher has time that would probably be best right now.

gadfort avatar Jul 27 '24 00:07 gadfort

@AcKoucher please help @LucasYuki with this as a first project.

maliberty avatar Aug 08 '24 04:08 maliberty

Should we have a "Find" option exclusively for the ClockTreeViewer or this sink highlighting should be triggered by the main window "Find"?

We could also have an item in the layout viewer context menu when right clicking a register that says something like "Show in clock tree viewer"

AcKoucher avatar Aug 08 '24 16:08 AcKoucher

I think the existing find mechanism is fine. The CTS viewer should just listen for selection in a similar fashion to the layout viewer.

maliberty avatar Aug 08 '24 17:08 maliberty

While talking to @arthurjolo and @AcKoucher we have the following question:

The existing find mechanism can find multiple instances in one search. In this case, how is the CTS viewer expected to behave?

What if we implement in the inspector a button, or an option with the right-click menu, to "find in the CTS viewer"?

LucasYuki avatar Aug 19 '24 19:08 LucasYuki

Is there a reason we couldn't support multi-select in the CTS viewer? When you get a select you zoom to the bounds of the selected object(s).

maliberty avatar Aug 19 '24 20:08 maliberty