OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

DRT: fix incremental updates in DRT

Open osamahammad21 opened this issue 1 year ago • 9 comments

DRT used to clear special nets routing if it was used more than once i.e. by calling detailed_route command after pin_access command or calling detailed_route command multiple times. This PR fixes this issue.

osamahammad21 avatar Jun 25 '24 12:06 osamahammad21

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 25 '24 12:06 github-actions[bot]

ready for review?

maliberty avatar Jun 25 '24 14:06 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 25 '24 23:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 26 '24 13:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 29 '24 16:06 github-actions[bot]

secure CI needed?

maliberty avatar Jun 29 '24 17:06 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 30 '24 11:06 github-actions[bot]

@maliberty I am having troubles with the metric updates resulting from this PR. Now, it's failing sky130hd_ibex with this which doesn't make any sense: ibex_sky130hd (tcl) *FAIL* DRT::max_capacitance_slack -11% < -11%

osamahammad21 avatar Jun 30 '24 12:06 osamahammad21

ibex_sky130hd (tcl) *FAIL* DRT::max_capacitance_slack -11% < -11%

My guess is that rounding is making this look odd (@vvbandeira ) and you should just update it. In the metric_limits

"DRT::max_capacitance_slack" : "-11.363490057317899"

maliberty avatar Jun 30 '24 15:06 maliberty

@maliberty The weird thing is that I updated it with the new value that I got from running the design on my local machine which is "DRT::max_capacitance_slack" : "-10.870980671686256". But I am getting a different value on jenkins!

osamahammad21 avatar Jul 01 '24 12:07 osamahammad21

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 02 '24 15:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 02 '24 19:07 github-actions[bot]

ibex_sky130hd (tcl) *FAIL* DRT::max_capacitance_slack -11% < -11%

My guess is that rounding is making this look odd (@vvbandeira ) and you should just update it. In the metric_limits

"DRT::max_capacitance_slack" : "-11.363490057317899"

We could change the formatting here: https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/test/flow_metrics.tcl#L133

vvbandeira avatar Jul 06 '24 11:07 vvbandeira

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 07 '24 16:07 github-actions[bot]