OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

mpl2: group snap functionalities in a class and avoid snapping twice

Open AcKoucher opened this issue 1 year ago • 2 comments

Changes:

  • Prepare mpl2 for removing the dbu <--> micron internal methods of conversion for the new dbBlock ones
  • Make place_macro not relying on mpl2 internals anymore
  • Avoid snapping when updating odb the first time

The minimal changes in macro_only test results are due to removing the unneeded snap.

If the approach is ok I'll run CI

AcKoucher avatar May 25 '24 16:05 AcKoucher

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 25 '24 16:05 github-actions[bot]

go ahead w/CI

maliberty avatar May 25 '24 17:05 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 21:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 27 '24 22:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 28 '24 21:05 github-actions[bot]

Opened #2036 for the metrics. So this should be good to merge.

AcKoucher avatar May 29 '24 15:05 AcKoucher

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 29 '24 15:05 github-actions[bot]