OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

grt: remove access point code from MakeWireParasitics

Open openroad-robot opened this issue 1 year ago • 4 comments

fastroute could potentially consider a different gcell other than ap_positions.front(), causing warnings.

openroad-robot avatar May 23 '24 15:05 openroad-robot

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 23 '24 15:05 github-actions[bot]

secure CI?

maliberty avatar May 23 '24 15:05 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 23 '24 15:05 github-actions[bot]

secure CI?

https://jenkins.openroad.tools/blue/organizations/jenkins/OpenROAD-flow-scripts-All-Tests-Private/detail/secure-grt-cleanup-pin-access/2/pipeline

I just did an update. The access point code shows in two functions, and I also removed the code in the second one.

gudeh avatar May 23 '24 15:05 gudeh

@maliberty this change should not affect the secure-ci, since we do not run pin_acess before GRT in ORFS. Also, I just reviewed the code and the change is correct.

eder-matheus avatar May 28 '24 19:05 eder-matheus