OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard
verified publisher icon The-OpenROAD-Project

Implementing callbacks for ScanDef parser and writer

Open fgaray opened this issue 1 year ago • 5 comments

Tested: read/write test in scandef_sky130.tcl

fgaray avatar May 22 '24 20:05 fgaray

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 22 '24 20:05 github-actions[bot]

ready for review?

maliberty avatar May 22 '24 20:05 maliberty

Yes, this is ready, thanks!

fgaray avatar May 22 '24 21:05 fgaray

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 30 '24 17:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jun 05 '24 22:06 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 16 '24 22:07 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 17 '24 00:07 github-actions[bot]

Hi @maliberty , sorry for the delay, this is ready for another look. Thanks!

fgaray avatar Jul 17 '24 02:07 fgaray

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 19 '24 22:07 github-actions[bot]

I am looking at the failures now

fgaray avatar Jul 20 '24 01:07 fgaray

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 23 '24 00:07 github-actions[bot]

Solved! I did not correctly updated sta/ when doing a merge from master.

fgaray avatar Jul 23 '24 01:07 fgaray