rsz: Document wire splitting reason

[povik]

On wire splitting in repair_design, name the inserted buffer according to the reason for splitting. A similar thing is done elsewhere in the repair code.

Split off from #5068

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[maliberty]

The code changes are fine but you need to update the tests.

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[github-actions[bot]]

clang-tidy review says "All clean, LGTM! :+1:"

[povik]

Now we are stuck on

+ ./test/regression jpeg_sky130hd
jpeg_sky130hd (tcl) *FAIL* DRT::max_slew_slack  -6% <  -2% ; DRT::max_capacitance_slack  -4% <  -2%
------------------------------------------------------
Failed 1/1
See /tmp/workspace/OpenROAD-Public_PR-5147-head/test/results/diffs for differences
See /tmp/workspace/OpenROAD-Public_PR-5147-head/test/results for log files
------------------------------------------------------
Found 1 tool regression failures.
script returned exit code 1

I guess the naming change influenced the iteration order somewhere downstream? How do I update those tests?

[maliberty]

save_flow_metrics save_flow_metrics_limits

[povik]

Thanks!

[maliberty]

This means this PR will need a full CI testing as it may change results on all ORFS designs. Let me know when it is ready for that.