OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Fix building `rmp_abc_library` when `USE_SYSTEM_ABC` is set

Open donn opened this issue 1 year ago • 6 comments

(Small change)

donn avatar May 15 '24 11:05 donn

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 15 '24 11:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 15 '24 11:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 15 '24 11:05 github-actions[bot]

I'm a bit confused by this. USE_SYSTEM_ABC is not mentioned anywhere in the PR beyond the title. What issue is being solved?

maliberty avatar May 21 '24 21:05 maliberty

When USE_SYSTEM_ABC is set to true, ABC_LIBRARY is set to a non-null value. Things that require abc link against ABC_LIBRARY so ABC symbols won't be missing for those who set USE_SYSTEM_ABC to true.

rmp_abc_library was just missing ABC_LIBRARY.

donn avatar May 22 '24 08:05 donn

rmp already links against it https://github.com/The-OpenROAD-Project/OpenROAD/blob/f0cc0ee1a62d7a6c35b43bd46a20980969eeb9a2/src/rmp/src/CMakeLists.txt#L73 - why does rmp_abc_library also need it (or should it just be moved)?

maliberty avatar May 22 '24 15:05 maliberty

Because otherwise rmp_abc_library which is I believe compiled as a standalone unit will complain about being unable to find things in the abc:: namespace.

donn avatar May 23 '24 12:05 donn