OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Add tooltips to Skew column

Open oharboe opened this issue 1 year ago • 2 comments

Description

Add a tooltip to explain in a sentence or two exactly what the Skew column is displaying.

image

See also https://github.com/The-OpenROAD-Project/OpenROAD/issues/5002 that has been following some bugfixes in Skew column.

Suggested Solution

Add a terse exact definition of the Skew column in tooltips.

Using this definition, it should be possible to corroborate that information in the Skew column with report_clock_skew or other sources in mock-array and mock-array/Element from within the OpenROAD GUI.

Additional Context

No response

oharboe avatar May 10 '24 05:05 oharboe

Do you have some text in mind?

maliberty avatar May 11 '24 01:05 maliberty

Do you have some text in mind?

@tspyrou ?

oharboe avatar May 11 '24 04:05 oharboe

Any ideas here?

AcKoucher avatar Jun 19 '24 15:06 AcKoucher

How about " path clock skew crpr corrected". Is that too long?

tspyrou avatar Jun 19 '24 19:06 tspyrou

How about " path clock skew crpr corrected". Is that too long?

Looks good. What is the equivalent OpenSTA syntax to reproduce this skew number?

oharboe avatar Jun 19 '24 19:06 oharboe

I'll also add the tooltips for the other new columns.

Would it be consistent to say:

Logic Delay: Non-buffer gate delays with no wire delay. Logic Depth: Number of instances apart from buffers and back-to-back inverters.

@maliberty One thing to note is we're not excluding sequential cells in theses logic metrics. Should we?

@oharboe Any opinions on these being too long?

AcKoucher avatar Jun 20 '24 13:06 AcKoucher

Looks good!

oharboe avatar Jun 20 '24 14:06 oharboe