OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Cts enable dummy load by deafult

Open arthurjolo opened this issue 1 year ago • 13 comments

This PR makes the CTS option to insert dummy load buffers at the end of CTS to be on by default.

arthurjolo avatar Apr 23 '24 12:04 arthurjolo

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 23 '24 12:04 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 23 '24 14:04 github-actions[bot]

I see a lot of failure that need addressing. A secure CI will be required once those are cleaned up

maliberty avatar Apr 23 '24 16:04 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 23 '24 16:04 github-actions[bot]

There are a bunch of conflicts to resolve

maliberty avatar Apr 24 '24 22:04 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 25 '24 16:04 github-actions[bot]

All the conflicts were resolved and now there is just one regression design that gets an error during DRT.

arthurjolo avatar Apr 25 '24 17:04 arthurjolo

Are you referring to aes_sky130hd (tcl) *ERROR* ?

maliberty avatar Apr 25 '24 18:04 maliberty

Are you referring to aes_sky130hd (tcl) *ERROR* ?

Yes, I have been talking with Osama on how to solve this.

arthurjolo avatar Apr 25 '24 18:04 arthurjolo

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 29 '24 17:04 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Apr 30 '24 13:04 github-actions[bot]

Has this been through secure CI? I don't see a lot of benefit in the OR tests. Is there a good example of the benefit somewhere?

maliberty avatar Apr 30 '24 16:04 maliberty

Yes it has been throw a CI, there are a lot of benefits. Cho has a table with the results. However there are 2 designs where the CI is failing and need to be rebased.

arthurjolo avatar Apr 30 '24 16:04 arthurjolo

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 01 '24 16:05 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 02 '24 23:05 github-actions[bot]

@precisionmoon Since we only use it at the end and just once I decided to make it an argument, but it can be added to the TritonCTS class if you believe to the best option.

arthurjolo avatar May 02 '24 23:05 arthurjolo

If the usage is very local then I would leave it

maliberty avatar May 02 '24 23:05 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar May 02 '24 23:05 github-actions[bot]