The-OpenROAD-Project
Dg replace merge
Hi Matt,
I added the init codes of DG-RePlAce. Could you please take a look ?
Thanks, Zhiang
@ZhiangWang033 needs clang-format and clang-tidy cleaned up. Also it needs to gracefully handle not having cuda installed.
Sorry, my bad. I modified the wrong files when I tested the DR.
I will fix this.
On Tue, Apr 16, 2024 at 9:44 AM Matt Liberty @.***> wrote:
@.**** commented on this pull request.
On src/drt/src/gr/FlexGR.cpp https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*discussion_r1567672245__;Iw!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsgMBP8HVo$ :
Why are there changes in drt? It seems unrelated. Using std::cout is not ok and would require use of the logger if these are intended.
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*pullrequestreview-2004156145__;Iw!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsg1R-My14$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQR3KJX5STLA3VGXGNOBBZLY5VIQDAVCNFSM6AAAAABGJTAKHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBUGE2TMMJUGU__;!!Mih3wA!C2AopV8Q_ntooHCylbsGVM6R6yRX3G2b1jye7hbRY80Ne02D1g3Yu3QrXM7METd1IpxJMGXulWTaj68fMOsgWfV-99U$ . You are receiving this because you were mentioned.Message ID: @.***>
Hi Matt,
I was busy with ICCAD submission. Will get it done this week.
Thanks, Zhiang
On Tue, May 7, 2024 at 2:46 PM Matt Liberty @.***> wrote:
@ZhiangWang033 https://urldefense.com/v3/__https://github.com/ZhiangWang033__;!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUu4gn8q4$ any eta for your updates?
— Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/The-OpenROAD-Project/OpenROAD/pull/4959*issuecomment-2099363841__;Iw!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUCz0dueE$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQR3KJTZPF6ZJHP27AYFGITZBFDULAVCNFSM6AAAAABGJTAKHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGM3DGOBUGE__;!!Mih3wA!F8hSd9ZaHzrG0NsaLl1bciK1wedwdKphoeZrc-NWPSjfUcJXGK-cIh24UTIiq-5DKXT0cnz-08nmtxUo7wXUjCtYlKo$ . You are receiving this because you were mentioned.Message ID: @.***>