OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

rsz: fail early if repair_setup sees a hopeless wns (> 4 * the clock …

Open openroad-robot opened this issue 1 year ago • 8 comments

…period)

Fixes #4908

openroad-robot avatar Apr 08 '24 21:04 openroad-robot

Will this trigger on super high fan-out nets? Those can often be fixed easily, but have really high wns

QuantamHD avatar Apr 08 '24 21:04 QuantamHD

Such nets should already have been fixed by repair_design.

maliberty avatar Apr 08 '24 21:04 maliberty

Kind of a bad experience though. Can we amend the error message to either check for the presence of high fanout nets, and or let the user know that repair_setup cannot fix high fanout nets.

QuantamHD avatar Apr 08 '24 22:04 QuantamHD

@QuantamHD @maliberty After TNS_END_PERCENT is 100 by default, isn't this pull request more important now?

Is there a lot to be done to finish it up?

oharboe avatar Jul 17 '24 05:07 oharboe

There were some failures at the time and I put it in the background. I can update and see where it is now.

maliberty avatar Jul 17 '24 16:07 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 17 '24 17:07 github-actions[bot]

@maliberty what is the resolution to @QuantamHD question about warnings?

gadfort avatar Jul 17 '24 17:07 gadfort

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Jul 17 '24 17:07 github-actions[bot]