OpenROAD
OpenROAD copied to clipboard
`DependencyInstaller.sh` touches system files
Describe the bug
On Ubuntu, DependencyInstaller.sh
seems to touch files installed by the system's package manager, even if you go the recommended route of setup.sh
from OpenROAD-flow-scripts
for a local install. I think it's reasonable to expect any dependency installer script to not do things like that.
Expected Behavior
.
Environment
N/A
To Reproduce
Look into https://github.com/The-OpenROAD-Project/OpenROAD/blob/master/etc/DependencyInstaller.sh#L292 where it stands:
# need the strip "hack" above to run on docker
strip --remove-section=.note.ABI-tag /usr/lib/x86_64-linux-gnu/libQt5Core.so
This runs for any Ubuntu installs, even local ones. This seems to be run from OpenROAD-flow-scripts/setup.sh
too.
Relevant log output
No response
Screenshots
No response
Additional Context
No response
@habibayassin, could you move this strip
command inside the Dockerfile/DockerHelper and make it conditional to run only on Ubuntu?