OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Assume port direction is input if io_type is unspecified in LEF.

Open mikesinouye opened this issue 1 year ago • 2 comments

in an offline chat with @maliberty, he suggests that even with an unknown type we should default to input.

mikesinouye avatar Mar 18 '24 21:03 mikesinouye

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 18 '24 22:03 github-actions[bot]

I am not in favor of this change as I think this is fixing a symptom rather than the root cause. The four legal values of dbIoType are handled in the current code. Somehow you are getting here with an invalid type. That is a critical problem and should be treated as such. How such an invalid value got into odb should be figured out and resolved at the source.

maliberty avatar Mar 18 '24 22:03 maliberty