OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

rsz: Makes pin swap equivalence algorithm more robust

Open QuantamHD opened this issue 1 year ago • 16 comments

Replaces the existing symbolic manipulation code with truth table evaluation.

Also changes the code to keep track of pin equivalence instead of "cell pin group" equivalence. Not all pins are equal to other pins as sky130_fd_sc_hd__o311ai_1 shows. The code would allow a more broad set of swapping to occur.

No functional change should be observed since the pin swap is limited to two term cells which would have worked under the old scheme.

QuantamHD avatar Feb 15 '24 20:02 QuantamHD

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 15 '24 20:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 15 '24 22:02 github-actions[bot]

Do I need to rebase against master @maliberty?

image

QuantamHD avatar Feb 16 '24 00:02 QuantamHD

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 16 '24 00:02 github-actions[bot]

rebasing is a good idea

maliberty avatar Feb 16 '24 01:02 maliberty

secure CI started

maliberty avatar Feb 16 '24 03:02 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 16 '24 03:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 16 '24 07:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 16 '24 07:02 github-actions[bot]

Looks like two flow tests need a metric update.

maliberty avatar Feb 16 '24 15:02 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 17 '24 20:02 github-actions[bot]

Metrics degraded slightly, but I created to PR to allow more than just 2 input nets. Once enabled there I see these metric regressions disappear.

QuantamHD avatar Feb 18 '24 21:02 QuantamHD

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 18 '24 21:02 github-actions[bot]

In asap7/aes-mbff I see

[INFO RSZ-0094] Found 162 endpoints with setup violations.
Error: cts.tcl, 107 _Map_base::at

Please take a look.

maliberty avatar Feb 20 '24 16:02 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 20 '24 16:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Feb 21 '24 05:02 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 13 '24 21:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 13 '24 21:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 13 '24 23:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 13 '24 23:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 14 '24 03:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 14 '24 03:03 github-actions[bot]

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Mar 14 '24 15:03 github-actions[bot]