OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

drt: replace name/xform with dbInst* in frInst

Open openroad-robot opened this issue 2 years ago • 5 comments

Save a bit of memory and a small step towards odb integration.

openroad-robot avatar Oct 25 '23 15:10 openroad-robot

@osamahammad21 does this have any effect on distributed routing? I don't see the frInst being serialized anywhere.

maliberty avatar Oct 25 '23 15:10 maliberty

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] avatar Oct 25 '23 17:10 github-actions[bot]

@osamahammad21 does this have any effect on distributed routing? I don't see the frInst being serialized anywhere.

No. I don't serialize frInst. Also I ran gcd_nangate45_distributed.tcl test and it works fine.

osamahammad21 avatar Nov 06 '23 22:11 osamahammad21

@maliberty Although I see that dbInst::getLocation is not the same as dbInst::getTransform().getOffset(). I didn't spend much time trying to understand why but just wanted to point it out.

osamahammad21 avatar Nov 06 '23 22:11 osamahammad21

@maliberty Although I see that dbInst::getLocation is not the same as dbInst::getTransform().getOffset(). I didn't spend much time trying to understand why but just wanted to point it out.

See the comment in db.h start "IMPORTANT - INSTANCE PLACEMENT". In short they will be different if the orientation is not N

maliberty avatar Nov 06 '23 22:11 maliberty