OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

make write_lef and others write out files atomically

Open oharboe opened this issue 2 years ago • 3 comments

Description

A half-written .lef file can be lying around after a crash which complicates e.g. deltaDebug.py.

Suggestion:

  1. modify all write_* commands to write to a temp file
  2. when the write completes, rename temp file to final name

This way there are no partial files lying around

Suggested Solution

No response

Additional Context

No response

oharboe avatar Jul 18 '23 22:07 oharboe

Hello @maliberty @oharboe , I'd like to work on this issue. Could you please assign it to me ?

annapetrosyan26 avatar Apr 26 '24 12:04 annapetrosyan26

@annapetrosyan26 You can simply create a pull request without being assigned this task, I don't have the role to assign github issues in this project.

I haven't seen that @maliberty assigns github issues to new contributors, but perhaps that's something that would be approperiate?

oharboe avatar Apr 26 '24 12:04 oharboe

Thank you @oharboe for the clarification. Then I'll work on the issue and once the code is ready I will create a pull request.

annapetrosyan26 avatar Apr 26 '24 14:04 annapetrosyan26

@maliberty Fixed, no?

oharboe avatar Jul 14 '24 06:07 oharboe

Fixed in https://github.com/The-OpenROAD-Project/OpenROAD/pull/5109

maliberty avatar Jul 14 '24 23:07 maliberty