OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Default colors in ASAP7 are too dark when used on black

Open oharboe opened this issue 2 years ago • 22 comments

Description

The text against black for these pins is illegible.

image

Suggested Solution

Have a default color scheme that's better adapted to be readable against black background.

Additional Context

Of course it is possible to change the colors in the GUI, but this feature request is about readability in the default case without needing to configure things.

oharboe avatar Apr 12 '23 10:04 oharboe

I've also noticed that the lowest layer color (dark blue / RGB(0, 0, 254)) is hard to see, eg the preferred/non preferred tracks. Perhaps the color palette used is more suited to a white background.

https://github.com/The-OpenROAD-Project/OpenROAD/blob/9f3dc03de34aacd843716e10988c80e56abc448d/src/gui/src/displayControls.cpp#L1726

antonblanchard avatar Apr 13 '23 03:04 antonblanchard

We could turn off the alpha for the text which would make it a bit clearer. The color of the text matches the layer color which is useful if you have pins on multiple layers.
image vs image We could just draw it in white as instead.

@gadfort @rovinski any preferences?

maliberty avatar Apr 13 '23 05:04 maliberty

I see that http://vrl.cs.brown.edu/color has changed some since I generated those colors (more knobs). I don't get the same set anymore fwiw. I'm open to suggestions. The first three layers have traditional values and I wouldn't change them too far.

maliberty avatar Apr 13 '23 05:04 maliberty

@maliberty I would prefer to preserve the color of the text to match that of the layer, so removing the alpha might be a good solution

gadfort avatar Apr 13 '23 11:04 gadfort

Indifferent

rovinski avatar Apr 13 '23 16:04 rovinski

@antonblanchard you might try setting the alpha=255 for m1 and see if that helps with tracks.

maliberty avatar Apr 13 '23 16:04 maliberty

@maliberty is this still a thing?

gadfort avatar Oct 18 '24 00:10 gadfort

Yes, still hard to see.

oharboe avatar Oct 18 '24 04:10 oharboe

I don't find it hard to see in this case image

do you disagree?

maliberty avatar Oct 18 '24 04:10 maliberty

I don't find it hard to see in this case image

do you disagree?

I find it hard to see, yes. I'll ask a few colleagues.

oharboe avatar Oct 18 '24 04:10 oharboe

Do you find it hard to see other shapes on that layer or just the text?

maliberty avatar Oct 18 '24 05:10 maliberty

Do you find it hard to see other shapes on that layer or just the text?

Both.

oharboe avatar Oct 18 '24 05:10 oharboe

The text against black for these pins is illegible.

If this a general color issue and not a text issue that's somewhat different. You can change the color by double clicking the color chip.

maliberty avatar Oct 18 '24 05:10 maliberty

The text against black for these pins is illegible.

If this a general color issue and not a text issue that's somewhat different. You can change the color by double clicking the color chip.

The feature request here is that openroad ships with color scheme(s) that don't have to be tweaked to get something readable.

oharboe avatar Oct 18 '24 05:10 oharboe

I tried http://vrl.cs.brown.edu/color with image image

and get image

How does that seem? Perhaps you can play around and see if you find a palette that works for you.

maliberty avatar Oct 18 '24 05:10 maliberty

Readability is subjective - I find it does that already. You need to be more specific/helpful to get anything to happen.

maliberty avatar Oct 18 '24 05:10 maliberty

Pointer to OpenROAD code where this is stored?

oharboe avatar Oct 18 '24 05:10 oharboe

Readability is subjective - I find it does that already. You need to be more specific/helpful to get anything to happen.

I'll try to make it quantitative: running a poll now.

oharboe avatar Oct 18 '24 05:10 oharboe

https://github.com/The-OpenROAD-Project/OpenROAD/blob/b972b34737c9382bbcf0ca492ecec74d3e958622/src/gui/src/displayControls.cpp#L1912

maliberty avatar Oct 18 '24 05:10 maliberty

@maliberty Quick poll by 3 colleagues no-one thought it was easy, 2x hard to read, 1x readable but could be brighted.

oharboe avatar Oct 18 '24 10:10 oharboe

I already gave a suggestion above but got no response.

maliberty avatar Oct 18 '24 19:10 maliberty

I made a PR... https://github.com/The-OpenROAD-Project/OpenROAD/pull/5982

oharboe avatar Oct 18 '24 20:10 oharboe