OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard
verified publisher icon The-OpenROAD-Project

Use standard naming for variables (ie snake case) in LEF58 parsers

Open osamahammad21 opened this issue 3 years ago • 6 comments

Use standard naming for variables (ie snake case).

Originally posted by @maliberty in https://github.com/The-OpenROAD-Project/OpenROAD/pull/2267#discussion_r971275243

osamahammad21 avatar Sep 15 '22 17:09 osamahammad21

@osamahammad21 Any update on this?

vijayank88 avatar Jun 22 '23 12:06 vijayank88

@vijayank88 This is a low priority issue at the moment. It's not done yet. It would be a good first issue for new comers.

osamahammad21 avatar Jun 25 '23 13:06 osamahammad21

Do you mean camel case instead? https://github.com/The-OpenROAD-Project/OpenROAD/pull/2267#discussion_r972247038 says EXCEPTEDGELENGTH should be rename to exceptEdgeLength but it's camel case not snake case. snake case would give except_edge_length.

titan73 avatar Aug 28 '24 00:08 titan73

Yeah sorry for misleading but we should use snake case not camel case: except_edge_....

osamahammad21 avatar Aug 28 '24 01:08 osamahammad21

We roughly intend to follow the Google style (https://google.github.io/styleguide/cppguide.html#Type_Names) though have lots of code that doesn't.

maliberty avatar Aug 28 '24 04:08 maliberty

Ah ok: type name => camel case variable => snake case constant => camel case mac style Pretty mixed style ;)

titan73 avatar Aug 28 '24 08:08 titan73