OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

initFloorplan() always snaps to grid

Open antonblanchard opened this issue 3 years ago • 1 comments

I was looking through warnings during a tape out and saw:

[WARNING IFP-0028] Core area lower left (5.520, 10.880) snapped to (5.520, 10.880).

I printed out the values, and it does look like the size of my macro is not a multiple of site:

clx 5520
core_lx 5.5199999860633405e-06
cly 10880 
core_ly 1.0879999972530641e-05

But it also seems like the comparison will never be true, because we are comparing a value that has been converted to Dbu:

      int clx = divCeil(metersToDbu(core_lx), site_dx) * site_dx;
      int cly = divCeil(metersToDbu(core_ly), site_dy) * site_dy;

      if (clx != core_lx || cly != core_ly) {

I presume this is harmless, but it would be nice to fix so the warning goes away.

antonblanchard avatar May 05 '22 21:05 antonblanchard

I was fixing up ifp for python and I think I've eliminated this problem in the process (both values are dbu now). Would you verify this is ok to close? There is no test case.

maliberty avatar May 19 '22 22:05 maliberty

Thanks @maliberty, I'm no longer seeing this.

antonblanchard avatar Oct 03 '22 22:10 antonblanchard