OpenROAD icon indicating copy to clipboard operation
OpenROAD copied to clipboard

Add check for off-grid dbBPin shapes

Open maliberty opened this issue 3 years ago • 1 comments

In https://github.com/The-OpenROAD-Project/OpenLane/issues/912 the root cause was an off-grid IO pin that lead to a pin access failure (all APs fail with off-grid errors).

We should have a pre-check at the start of routing that runs gc on each of the dbPin to give a clearer warning about such a problem.

maliberty avatar Feb 10 '22 21:02 maliberty

On a related note, maybe it's a good idea to force place_pin to snap to the manufacturing grid.

rovinski avatar Feb 11 '22 11:02 rovinski

@maliberty I recently came across similar PR related to off-grid check. It's resolved right?

vijayank88 avatar Jun 19 '23 10:06 vijayank88

@osamahammad21 is this covered by your recent change?

maliberty avatar Jun 19 '23 11:06 maliberty

No, my previous PR checks on cells only.

osamahammad21 avatar Jun 19 '23 11:06 osamahammad21

@refaay Please take care of this. Refer to void io::Parser::checkPins() in io_parser_helper.cpp and apply the same checks to the bterms. Try not to duplicate code.

osamahammad21 avatar Aug 29 '23 12:08 osamahammad21

Issue solved in PR #3961.

refaay avatar Sep 25 '23 13:09 refaay