OpenROAD-flow-scripts icon indicating copy to clipboard operation
OpenROAD-flow-scripts copied to clipboard

Manual macro placement configuration not read by RTLMP2

Open vijayank88 opened this issue 1 year ago • 7 comments

Subject

Describe the bug

Based fixed macro location with macro.cfg RTLMP flow not placing in right co-ordinates.

Expected Behavior

Macros should be placed based on export MACRO_PLACEMENT = ./designs/$(PLATFORM)/$(DESIGN_NICKNAME)/macro.cfg

Environment

with latest master

To Reproduce

Due to file size limit uploaded here: https://drive.google.com/file/d/1Rvno9adoQkzrV6ewoT_LXogtc1EgWzr4/view?usp=share_link

Relevant log output

No response

Screenshots

No response

Additional Context

No response

vijayank88 avatar Mar 30 '23 15:03 vijayank88

If you manually place the macros then you shouldn't be using rtlmp.

maliberty avatar Mar 31 '23 05:03 maliberty

Thanks @maliberty.

We have requested documentation for RTLMP tool from @ravi-varadarajan.

The issues was reported by Jignesh from USC_ext.

vijayank88 avatar Apr 01 '23 05:04 vijayank88

This is an enhancement request. mpl2 should be able to handle cases where some of the macros are pre-placed

ravi-varadarajan avatar Apr 01 '23 13:04 ravi-varadarajan

The issue is that orfs doesn't call mpl2 when you give a config file as it assumes all macros are placed.

maliberty avatar Apr 01 '23 14:04 maliberty

This check to read the manual macro placement is only for TMP and not for rtlmp2. I will add it to mpl2 too in macro_place.tcl. However we will need to support some of the macros being pre-placed in the flow. I will create an enhancement request and assign it to me.

ravi-varadarajan avatar Apr 01 '23 15:04 ravi-varadarajan

@ravi-varadarajan Any update on this?

vijayank88 avatar Aug 17 '23 07:08 vijayank88

There are two different things here

  • MACRO_PLACEMENT_TCL/MACRO_PLACEMENT should be used even if RTLMP_FLOW is set which is a trivial change. I can do this.
  • mpl2 should support partial macro placement which is probably a lot of work. This will be an enhancement request to OR. @ravi-varadarajan did you open one as you said?

maliberty avatar Aug 17 '23 16:08 maliberty