OpenROAD-flow-scripts icon indicating copy to clipboard operation
OpenROAD-flow-scripts copied to clipboard
verified publisher icon The-OpenROAD-Project

Fixed handling to CTS flow variables

Open jeffng-or opened this issue 9 months ago • 4 comments

Includes the following mods:

  1. Fixed calling of append_env_var in cts.tcl since the argument order was incorrect
  2. Added CTS_BUF_LIST env var (also updated variables.yaml document)
  3. Updated rules files for three designs (ihp-sg13g2/ibex, ihp-sg13g2/riscvi, sky130hd/microwatt) which explicitly set CTS_BUF_DISTANCE. Due to item 1 above, the flow variable was ignored
  4. Included at- in branch name to run AutoTuner tests (all autotuner.json files include CTS_CLUSTER_DIAMETER and CTS_CLUSTER_SIZE in their parameter list

CI Could not Update Rules

[ERROR] asap7/gcd: No metrics found, please check the latest CI build for issues. [ERROR] ihp-sg13g2/gcd: No metrics found, please check the latest CI build for issues. [ERROR] sky130hd/gcd: No metrics found, please check the latest CI build for issues.

jeffng-or avatar Mar 24 '25 21:03 jeffng-or

The changes look fine but I'm confused why I see the updaterules label has been removed but the pr-merge is still running. @vvbandeira do you understand?

maliberty avatar Mar 25 '25 15:03 maliberty

The action incorrectly assumed that the CI had finished when it saw pr-head done. I will fix upstream.

vvbandeira avatar Mar 25 '25 17:03 vvbandeira

@vvbandeira , please let me know if there's something actionable for me on this PR.

jeffng-or avatar Mar 26 '25 15:03 jeffng-or

@vvbandeira , please let me know if there's something actionable for me on this PR.

There's a conflict with the AT pipeline and UpdateRules label; I hope #3004 will fix it.

vvbandeira avatar Mar 26 '25 21:03 vvbandeira

Replaced by https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/3066

jeffng-or avatar Apr 11 '25 22:04 jeffng-or