OpenROAD-flow-scripts
OpenROAD-flow-scripts copied to clipboard
The-OpenROAD-Project
Fixes for `KLAYOUT` in Makefile
Two fixes to the KLAYOUT in Makefile stuff;
- Fix the discovery of the KLayout binary (fixes #1494).
- Expand the
$(shell)usage straight away.
Metric fails bp_multi_top nangate45
[ERROR] detailedroute__route__drc_errors fail test: 3.0 <= 0.0
Metric fails bp_multi_top nangate45
[ERROR] detailedroute__route__drc_errors fail test: 3.0 <= 0.0
This happens before klayout is used...
If I remember correctly, @rovinski had a point about not using := for klayout as some people do not care about it/use other tools at the end of the ORFS flow. If we use :=, then klayout must be present to run any stage of the flow. Please correct me if I am mistaken.
We could change the Makefile to disable the KLAYOUT functionality if KLAYOUT is not found (rather than producing the error).
It's an interesting problem to handle the difference in expectations. Some users want the GDS produced by KLayout and would be confused if the flow completed without error without producing GDS. Some users don't care about GDS and just want to prototype without having to jump through extra hoops.
The current solution allows the flow to run without error until KLayout is actually required. It would be great if it could maintain that functionality.
@mithro is this still relevant? It appears there was no consensus on this change.
It is definitely still relevant. It bit me with the same obscure "illegal shell option" error message just because klayout was not installed (see the referenced ORFS issue #1494 to see how ugly it is). The PR is a huge step forward over the existing behavior. It would be better to just skip the klayout dependent steps but that requires more work than merging this.
