ThaumicTinkerer icon indicating copy to clipboard operation
ThaumicTinkerer copied to clipboard

Osmotic Enchanter doesn't lose your settings when you add/remove a wand before starting enchantment

Open SarahKirksey opened this issue 3 years ago • 2 comments

I can't tell you how many times I've configured a tool or weapon with the perfect enchantment set, realized there's no wand in the table, and added a wand before clicking the button to start the enchantment. Every time, I died a little inside. I've spoken with others, and the ones who have also done this have agreed that this behavior is not desired. Since I was modifying the code to fix the Infused Seeds bugs, adding one more change to the mix was easy enough. So, I set the enchanter to stop scrubbing the configured enchantments every time the block is marked dirty.

SarahKirksey avatar Jan 12 '22 03:01 SarahKirksey

This one will need more testing before it is PR'd, as this is for an older version this will take more then a couple days. The previous behaviour was due to exploits that occurred, and I need to make sure it does not re-introduce them, or if people are having trouble, find a new way to patch

GaeaKat avatar Jan 12 '22 03:01 GaeaKat

That's more than fair! Thank you for the prompt responses! Do you have any additional information regarding the nature of the exploits in question?

SarahKirksey avatar Jan 12 '22 03:01 SarahKirksey