web-ifc-three icon indicating copy to clipboard operation
web-ifc-three copied to clipboard

Last web-ifc implementation is not compatible with the last web-ifc-three implementation

Open jespa007 opened this issue 2 years ago • 6 comments

Hi there,

If I try to build current implementation of web-ifc-three (i.e 0.0.122) with the lastest implementation of web-ifc it throws the following errors,

image

So web-ifc-three it has to be adapted with the latest changes of web-ifc, because some signatures were changed since web-ifc 0.0.36

jespa007 avatar Feb 07 '23 16:02 jespa007

@agviegas , I thing I've achieved make compatible last implementation web-ifc with last implementation of web-ifc-three. I'll make PR with the steps to update web-ifc in a while

jespa007 avatar Feb 08 '23 11:02 jespa007

@agviegas , I think it has no sense do a PR that makes compatibles to the last web-ifc, because people will still use web-ifc from npm and to build web-ifc, copy files is not easy task. But anyway, tell me if you are interested or not still in do the PR

jespa007 avatar Feb 08 '23 13:02 jespa007

So there have been a few API changes to support multi-schema in the new web-ifc. My suggestion is wait for us to get the new version of web-ifc done then adapt web-ifc-three

beachtom avatar Feb 09 '23 10:02 beachtom

So there have been a few API changes to support multi-schema in the new web-ifc. My suggestion is wait for us to get the new version of web-ifc done then adapt web-ifc-three

I agree with that @beachtom

jespa007 avatar Feb 09 '23 10:02 jespa007

Agreed! Both web-ifc-three and web-ifc-viewer need a big update / clean up, so this might be a good opportunity.

agviegas avatar Feb 11 '23 13:02 agviegas

I opened IFCjs/web-ifc-viewer#188 a few minutes ago and discovered this one afterwards. I guess both are intermingled. This comment to cross-reference both.

olange avatar Feb 16 '23 18:02 olange