ThatOpen
[Bug]: Wrong representation of window
What happened?
I integrated the viewer of That Open Company in our application (Angular application written in TypeScript) and if I load an IFC model that we created in ArchiCAD, two of the windows are shown in a very strange way (see attached images - issue1, issue2). In ArchiCAD as well as in another viewer (BIMCollabZoom), the model looks as expected (see attached image - normal). So, I'm not sure what exactly is wrong in the rendering of this model but there seems to be a bug. Could someone have a look at this or get in touch with me if further information are needed. I could also share the model if that would help, just let me know so that I can share it privately.
Hint: I load it as well on the demo page (https://thatopen.github.io/engine_web-ifc/demo/) and checked how it looks and the issue is the same as in my application.
Issue1
Issue 2
normal (working in BIMCollabZoom)
Version
0.0.53
What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Anything else?
No response
Yes, sure. Is there an easy way I can share the model with you privately?
Please send it to [email protected], specifying the issue it relates to, and mention that this model is for @QuimMoya.
Last improvements in fuzzy bools library greatly reduced the issues in your model, still some bugs anyway.
@QuimMoya Thanks for the input and sorry for getting back to you that late but I either didn't see the notification or it went to my spam somehow. So, that means you improved already a bit in this direction. I actually just had similar if not even more severe viewing issues recently where a model looked like this:
So, it seems that several things can't be shown correctly. Since you already started to improve several things, do you know why it looks so weird?
...because this is quite a blocker for us because customers will not gain any trust in a viewer that shows models in such a funky way
I will send you the file again via mail so that you have everything you need to localise the issue.
BTW, I use these versions if that helps as information: "@thatopen/components": "^2.2.3", "@thatopen/components-front": "^2.0.6", "@thatopen/fragments": "^2.0.4", "@thatopen/ui": "^2.0.8", "@thatopen/ui-obc": "^2.0.9", "bim-fragment": "^1.5.0", "three": "^0.160.1", "web-ifc": "^0.0.57",
In what version of web-ifc are your changes included?
@QuimMoya Hey a guy from the That Open Community had a look into the issue and gave the following feedback that might also help in this case: I did take a quick look, I'm not sure what the cause is
- I ruled out normals by rendering both sides of all faces (it looks like on https://thatopen.github.io/engine_web-ifc/demo/) (geometry still broken)
- I get no web-ifc errors when loading the file
- It looks fine in blender, although the triangulation is a little weird
- The broken geometry can be traced back to IFCPOLYGONALFACESET so I'm thinking that either:
- the web-ifc triangulation has a bug https://github.com/ThatOpen/engine_web-ifc/blob/8179ec4ca51624989bdf9289b8c8e326d042ca2f/src/cpp/geometry/IfcGeometryProcessor.cpp#L554
- or the exported polygons don't respect the conditions here: https://standards.buildingsmart.org/IFC/RELEASE/IFC4/ADD2_TC1/HTML/schema/ifcgeometricmodelresource/lexical/ifcpolygonalfaceset.htm
I hope that helps ;-)
Hey @QuimMoya, did you have the chance to look into this issue by any chance? It seems that quite some people have similar issues with this. If I can help in any way let me know.
@QuimMoya Thanks for the input, that looks much better. Is the updated version already available in a new web-ifc release so that I can test it? (looking forward to it a lot 🤗)
@QuimMoya Thanks for the input, that looks much better. Is the updated version already available in a new web-ifc release so that I can test it? (looking forward to it a lot 🤗)
yes there is something already released. Dunno if everything. Looks much better, but not all problems are solved...
Thanks for the quick reply...will check whether I can update and test it in that case 👍🏻
@agviegas Ok, thanks for the reply. Can you tell already in what version of web-ifc all the changes will be included so that I check for that version before I do my testing?