engine_fragment icon indicating copy to clipboard operation
engine_fragment copied to clipboard

Handle DoubleSided materials

Open MadsHolten opened this issue 2 years ago • 4 comments

Related to this PR on OBC. Fix here first and create a new build that will be used in OBC.

MadsHolten avatar Dec 23 '22 11:12 MadsHolten

Hey, as double sided materials are more consuming that single-sided materials, I'm not sure if double-side should be the default 🤔 would a for loop to make all materials double sided be very inconvenient?

agviegas avatar Jun 12 '23 16:06 agviegas

On the other hand you know that the quality of IFCs can vary and I often find weird looking models because of this. I am currently handling it with a for loop.

MadsHolten avatar Jun 13 '23 14:06 MadsHolten

Hm, I see. Right now we are making huge fragment optimizations. Once we are done, maybe we can test both options (with and without) on various devices and see the results? If you want to be involved in that benchmark, let us know!

agviegas avatar Jun 15 '23 09:06 agviegas

Sure. Keep me posted :)

tor. 15. jun. 2023 11.31 skrev Antonio González Viegas < @.***>:

Hm, I see. Right now we are making huge fragment optimizations. Once we are done, maybe we can test both options (with and without) on various devices and see the results? If you want to be involved in that benchmark, let us know!

— Reply to this email directly, view it on GitHub https://github.com/IFCjs/fragment/pull/2#issuecomment-1592700413, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADH3QEIZKA3CQVCFLTMPSS3XLLI6JANCNFSM6AAAAAATHUYOJ4 . You are receiving this because you authored the thread.Message ID: @.***>

MadsHolten avatar Jun 15 '23 10:06 MadsHolten

Closing this for now! I think that staying on the performance side by default is better, and a small loop is a small price to pay IMO 🙏🏻 Thanks a lot for this BTW! We will soon publish some guidelines for contributing to make all this easier

agviegas avatar May 22 '24 20:05 agviegas