helm-spray icon indicating copy to clipboard operation
helm-spray copied to clipboard

Restore enabled parameter to its initial meaning

Open cvila84 opened this issue 5 years ago • 1 comments

today, enabled parameter is used by spray to manage the order of deployment of sub-charts (e.g. all sub-charts enabled are set to false, and the sub-chart to be deployed has its enabled parameter set to true, and so on, to deploy all the sub-charts one by one).

it brings confusion especially because we may want to use enabled in a provided values.yaml to indicate we would like to deploy only a part of the umbrella chart (which is better than always use the --target or --exclude flag)

cvila84 avatar Jul 23 '19 08:07 cvila84

we may want to use enabled in a provided values.yaml to indicate we would like to deploy only a part of the umbrella chart (which is better than always use the --target or --exclude flag)

I'm not sure this is "better" than using the --target or --exclude, because these flags are the "official"/"visible" way to specify charts to be deployed or not; while the usage of the enabled value is the "internal"/"hidden" solution to do that. My feeling is that we should avoid making such internal cooking be made available to the outside world (i.e. as a public "api").

More that that, how to manage a call to Helm Spray with both the --exclude flag on a chart and the enabled value for the same chart being set to true?

pamiel avatar Jul 25 '19 07:07 pamiel