miru [Feature Request]: Flatpak Support.

[Feature Request]: Flatpak Support.

Open Atkoset opened this issue 2 years ago • 16 comments

Preflight checklist

[X] I have searched the issue tracker for a bug report that matches the one I want to file, without success.
[X] I have searched the features list for this feature, and I couldn't find it.
[X] I have checked that I'm using the latest stable version of the app.

Problem Description

Hello, I would like to see the Flatpak packaging to streamline updates with the package manager so everything can be updated all at once when doing system updates on the Steamdeck. Since many Linux distro's come with the Flatpak package manager they will better and more easily integrate with SteamOS other Linux distro's. So the main features are:

Easy to develop.
Easy to maintain and install on the users end.
Easy to update and manage.
Very stable
Consistent environments

Proposed Solution

My proposed solution would be to slowly transition over to Flatpak and have that as another option for Linux users.

Jun 05 '22 17:06 Atkoset

I wont pursue this, but I'll accept a PR

Jun 05 '22 18:06 ThaUnknown

Unfortunately due to my personal circumstances I won't be able to do this, so I recommend keeping this issue open for in the future as a possibility or for someone looking to contribute to the project by accepting tickets.

Jun 06 '22 15:06 Atkoset

Hey there, @ThaUnknown! I started working on the flatpak, but got halted at an error which involves a few problems with the .desktop file. It might be worth another issue, but let's see what you think about it.

The "Video" category requires another category called "AudioVideo" as well.
The "Anime" category is an unregistered value, so it should be renamed to "X-Anime" or completely removed.
At "MimeType" "x-scheme-handler/miru" is included twice. Though not an error, but a warning.

Hopefully, fixing these minor problems will also grant the way for the flatpak too.

Aug 19 '22 16:08 sambuca1g

You can straight up remove Anime and add AudioVideo to match the freedesktop specifications on registered categories, theres no real threat to it as it won't break anything.

One of the MimeTypes can be removed in package.json if protocol is later tested on a fresh install and works for both .AppImage (test this first) and .deb (test this second). I remember electron having ambiguous documentation on linux mimetypes so I added both just in case.

I'll reopen this issue since you want to pursue this.

Aug 19 '22 17:08 Muril-o

Hey there, @ThaUnknown! I started working on the flatpak, but got halted at an error which involves a few problems with the .desktop file. It might be worth another issue, but let's see what you think about it.

The "Video" category requires another category called "AudioVideo" as well.

The "Anime" category is an unregistered value, so it should be renamed to "X-Anime" or completely removed.

At "MimeType" "x-scheme-handler/miru" is included twice. Though not an error, but a warning.

Hopefully, fixing these minor problems will also grant the way for the flatpak too.

PR this an I'll merge it

Aug 19 '22 17:08 ThaUnknown

PR this an I'll merge it

Alright, so it is really not needed to now because I can just source a modified .desktop file. If you want to change it though, it's up to you.
Anyways, I got it working using the AppImage and it is performing pretty well. Are there any specific filesystem permissions that I should add, like access to Downloads folder? I kept it really minimal.

Aug 20 '22 07:08 sambuca1g

just... PR the changes

not that I'd know, as you can see I don't use/test linux

Aug 20 '22 11:08 ThaUnknown

just... PR the changes

not that I'd know, as you can see I don't use/test linux

Did a PR.

Aug 20 '22 13:08 sambuca1g

Okay. I set up a repo, feel free to check it out. I'll have to double check the permissions though.
Now the question is: should we post it to Flathub? It'll definitely bring a broader userbase. However, I don't know if they consider using this project as piracy and if they would allow it.

Aug 28 '22 19:08 sambuca1g

Okay. I set up a repo, feel free to check it out. I'll have to double check the permissions though. Now the question is: should we post it to Flathub? It'll definitely bring a broader userbase. However, I don't know if they consider using this project as piracy and if they would allow it.

... PR it

Aug 28 '22 19:08 ThaUnknown

Okay. I set up a repo, feel free to check it out. I'll have to double check the permissions though. Now the question is: should we post it to Flathub? It'll definitely bring a broader userbase. However, I don't know if they consider using this project as piracy and if they would allow it.

... PR it

Considering that qbittorent and one other similar app to Miru is offered there It should be safe to post it on Flathub.

Sep 20 '22 19:09 Atkoset

I was able to successfully install using the repository built in the mentioned issue: https://github.com/flathub/flathub/pull/4139#issuecomment-1542299767

Also fixes a problem I was having signing in which was present with the AppImage.

May 11 '23 03:05 TomatDividedBy0

It's available. With the merge of #271, I think we can close this issue.

May 11 '23 12:05 sambuca1g

For me flatpak don't want to launch, I get this when I try to run it:

09:26:20.353 › APPIMAGE env is not defined, current application is not an AppImage
LaunchProcess: failed to execvp:
xdg-settings
09:26:20.360 › checkForUpdatesAndNotify called, downloadPromise is null
[3:0913/092620.361863:ERROR:ozone_platform_x11.cc(240)] Missing X server or $DISPLAY
[3:0913/092620.361901:ERROR:env.cc(255)] The platform failed to initialize.  Exiting.
The futex facility returned an unexpected error code.
/app/bin/miru-run: linia 3:     3 Przerwane               zypak-wrapper /app/bin/miru/miru "$@"