miru icon indicating copy to clipboard operation
miru copied to clipboard

MyAnimeList support

Open Zabooby opened this issue 2 years ago • 18 comments

Is support MAL sync planned?

Zabooby avatar Apr 10 '22 13:04 Zabooby

no, MAL API is just dogshit [on the rare occasion it works], and I don't want to rely on fan-made 3rd part API's for MAL

however AniList exposes MAL ID's for most anime, so someone could easily make a PR based on that, which I'd likely accept

invalid issue template

ThaUnknown avatar Apr 10 '22 13:04 ThaUnknown

I can't even look at their documentation https://haven.pages.dev/video-player/public/?file=https://cdn.discordapp.com/attachments/631919775613845504/962704977464266762/Desktop_2022.04.10_-_15.22.55.05.mp4

ThaUnknown avatar Apr 10 '22 13:04 ThaUnknown

Couldn't you just copy taiga's implementation of MAL,they seem to have it working?

https://github.com/erengy/taiga

Zabooby avatar Apr 10 '22 13:04 Zabooby

image image no lol

ThaUnknown avatar Apr 10 '22 13:04 ThaUnknown

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

Zabooby avatar Apr 10 '22 13:04 Zabooby

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

image

ThaUnknown avatar Apr 10 '22 13:04 ThaUnknown

https://myanimelist.net/apiconfig/references/authorization https://myanimelist.net/static/apiagreement.html https://myanimelist.net/apiconfig/references/api/v2

Can you see these, maybe its because you don't have a MAL account?

Zabooby avatar Apr 10 '22 13:04 Zabooby

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

Zabooby avatar Apr 10 '22 14:04 Zabooby

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

that video is the perfect example of why I don't bother supporting MAL, if some1 makes a PR for it, I'll accept it, but I don't plan on working on it myself

ThaUnknown avatar Apr 10 '22 14:04 ThaUnknown

Hi 👋🏻 I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

Olyno avatar Apr 14 '22 09:04 Olyno

Hi 👋🏻 I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

I recommend u read the list of features https://github.com/ThaUnknown/miru#features anilist is already supported, idk how u missed the big ass "login with anilist" button in the corner

ThaUnknown avatar Apr 14 '22 10:04 ThaUnknown

Oops sorry I didn't see it, I just stumbled upon this issue by chance, I should have been more careful, my apologies

Olyno avatar Apr 14 '22 11:04 Olyno

Would any of these help with adding mal support?

https://github.com/Kylart/MalScraper https://github.com/Chris-Kode/myanimelist-api-v2 https://github.com/jikan-me/jikan

Zabooby avatar Apr 29 '22 16:04 Zabooby

image image no lol

Maybe I'm completely misunderstanding how it works (I've only looked into Wasm pretty briefly), but couldn't you compile the C++/C code to Wasm and use it with your JavaScript code that way?

YUKI2eN3e avatar May 06 '22 20:05 YUKI2eN3e

wow i cringed

It's not that its not possible in JS, its that i cant be fucking arsed to do it, because of how dogshit MAL is

ThaUnknown avatar May 06 '22 20:05 ThaUnknown

Reopening this since its a good feature that many people would benefit from. It's not impossible, just troublesome because MAL has chosen it to be. As ThaUnknown said, he won't work on it himself but will accept PRs if someone else is willingly to implement.

Muril-o avatar May 07 '22 00:05 Muril-o

Hello, could you add Kitsu API too if possible? Kitsu is comparable to Anilist in the way that it also syncs your anime. Where it differs is that it's fully opensource option that a lot of people including me use since it's opensource it shouldn't take too much work to integrate I hope. I have included a link to their API repo below.

https://github.com/hummingbird-me/api-docs

@ThaUnknown

Atkoset avatar Jun 04 '22 16:06 Atkoset

as I stated before, I won't be pursuing this, but I'm open to accept PRs for it

ThaUnknown avatar Jun 04 '22 16:06 ThaUnknown