Martin Keckeis

Results 75 comments of Martin Keckeis

Last release was in `September` https://github.com/serbanghita/Mobile-Detect/releases

Since the `3.x` release seems to be waiting, we will add this package, which is based on MobileDetect, but offers name detection https://github.com/jenssegers/agent //cc @jenssegers

@serbanghita do you already have a target date for `3.0` ?

@cedricalfonsi the check was done that way when i started with the package (but it was not testable) https://github.com/ThaDafinser/UserAgentParser/blob/8318722a977b89f66c4d6b9b7bc4a013875f8449/src/Provider/DonatjUAParser.php#L43-L45 But since this package only supports [composer](https://getcomposer.org/) for installation, i wasn't...

@cedricalfonsi any idea? I'm pretty sure we could do this better somehow I'll close the PR in the meantime

@cedricalfonsi i was thinking about this a while (that's why i reply so late, sorry about that) By doing `dirname(dirname(dirname(dirname(__DIR__))))` we limit ourself again to a fixed structure. So that...

Now i get you. You use this option? https://getcomposer.org/doc/03-cli.md#composer-vendor-dir

@cedricalfonsi i think we implement this in `2.0`. If we change the code to your variant `dirname(dirname(dirname(dirname(__DIR__))))` we would also need a check if the folder exists, since that wont...

Some have this information, but not that many. For what you need this information?

Makes sense. For now you could use the `$result->getProviderResultRaw();` and depending on the provider there will be different fields field out.