UserAgentParser icon indicating copy to clipboard operation
UserAgentParser copied to clipboard

new provider mimmi20

Open ThaDafinser opened this issue 7 years ago • 5 comments

@mimmi20 can u do a review, if i map the correct fields?

ThaDafinser avatar May 11 '17 08:05 ThaDafinser

@mimmi20 got all things covered now, will update the PR tomorrow :+1:

ThaDafinser avatar May 17 '17 06:05 ThaDafinser

@mimmi20 can u do a last review?

The question is now...

  • creating v2.x (and do maintenance for 1.x)
  • or just create a new v1.x with higher requirements...
  • or leave 5.6 requirement (since it will fail, when your package is required)

Need to think about that a bit

ThaDafinser avatar May 19 '17 13:05 ThaDafinser

@ThaDafinser I do not have the time to maintain two versions. I am still working on the complexity, and I am still adding devices and browsers which are not detected yet. I dont want to add PHP 5.6 to my supported PHP versions because I want to add PHP 7+ features in the future.

mimmi20 avatar May 19 '17 23:05 mimmi20

@mimmi20 leave your package as php 7+.

it was more about this package ;-)

ThaDafinser avatar May 20 '17 06:05 ThaDafinser

@ThaDafinser Any news here?

mimmi20 avatar Dec 04 '17 07:12 mimmi20