Texture icon indicating copy to clipboard operation
Texture copied to clipboard

fix format specifier

Open joprice opened this issue 5 years ago • 1 comments

This applies the suggested fix that shows up when ASEnableVerboseLogging is enabled:

external/Texture/Source/ASNetworkImageNode.mm:891:144: error: enum values with underlying type 'NSInteger' should not be used as format arguments; add an explicit cast to 'long' instead [-Werror,-Wformat]
            as_log_verbose(ASImageLoadingLog(), "Decached image for %@ img: %@ url: %@ cacheType: %@", self, [imageContainer asdk_image], URL, cacheType);```

joprice avatar Jan 24 '21 20:01 joprice

I'm trying to verify this change by using build.sh, but I have a newer sdk. When I provide TEXTURE_BUILD_PLATFORM and TEXTURE_BUILD_SDK with my current versions, I get errors related to missing extern modifiers, etc. It seems that -Werror, and I'm not sure if that's intentional and the sdk version caused this, or if these warnings are expected and I'm supposed to ignore them somehow.

Up until now, I've been testing this by building it via bazel using PodToBuild, but I'd like to be able to test it directly and run the tests (or perhaps bazel support could be added directly?).

joprice avatar Jan 31 '21 16:01 joprice