Texture icon indicating copy to clipboard operation
Texture copied to clipboard

Compiling Texture fails on Xcode 12 due to incompatibility of PINRemoteImage library

Open udayasri opened this issue 4 years ago • 11 comments

When using Texture with Carthage, compile fails on Xcode 12. Reason for this Texture still uses old implementation of PINRemoteImage & PINCache libs. Cartfile should be update to use master branches as issue is fixed in the master branch.

github "pinterest/PINRemoteImage" "3.0.0-beta.14" github "pinterest/PINCache" "3.0.1-beta.7"

I created a PR for this issue : https://github.com/TextureGroup/Texture/pull/1908

udayasri avatar Sep 18 '20 05:09 udayasri

same think when we using cocoapods

MeGaPk avatar Sep 21 '20 07:09 MeGaPk

Same here.

Mammadbayli avatar Sep 21 '20 08:09 Mammadbayli

problem on texture 2.8.1 via cocoapods... please update this version also

MeGaPk avatar Sep 21 '20 12:09 MeGaPk

the same

istepler avatar Oct 06 '20 17:10 istepler

  post_install do |installer_representation|
        installer_representation.pods_project.targets.each do |target|
            if target.name == "PINCache" or target.name == "PINRemoteImage"
                puts "Updating #{target.name} OTHER_CFLAGS"
                target.build_configurations.each do |config|
                    config.build_settings['OTHER_CFLAGS'] = '-Xclang -fcompatibility-qualified-id-block-type-checking'
                end
            end
        end
    end

temp fix that

MeGaPk avatar Oct 06 '20 18:10 MeGaPk

@MeGaPk thanks

istepler avatar Oct 07 '20 05:10 istepler

  post_install do |installer_representation|
        installer_representation.pods_project.targets.each do |target|
            if target.name == "PINCache" or target.name == "PINRemoteImage"
                puts "Updating #{target.name} OTHER_CFLAGS"
                target.build_configurations.each do |config|
                    config.build_settings['OTHER_CFLAGS'] = '-Xclang -fcompatibility-qualified-id-block-type-checking'
                end
            end
        end
    end

temp fix that

Worked, thanks!

Mammadbayli avatar Oct 20 '20 05:10 Mammadbayli

  post_install do |installer_representation|
        installer_representation.pods_project.targets.each do |target|
            if target.name == "PINCache" or target.name == "PINRemoteImage"
                puts "Updating #{target.name} OTHER_CFLAGS"
                target.build_configurations.each do |config|
                    config.build_settings['OTHER_CFLAGS'] = '-Xclang -fcompatibility-qualified-id-block-type-checking'
                end
            end
        end
    end

temp fix that

it's works!thank u very much!

jiachangdangniban avatar Nov 27 '20 01:11 jiachangdangniban

@MeGaPk Solution is only for cocoapods, does anybody know how can use fix this for carthage ?

udayasri avatar Feb 03 '21 07:02 udayasri

sir, sorry about that, we user the cocoapods only, we have no idea how to figure it out on carthage. have nice day:) 

--

       顺颂,

 

商祺。

 

------------------ 原始邮件 ------------------ 发件人: "Udaya Sri Senarathne"<[email protected]>; 发送时间: 2021年2月3日(星期三) 下午3:00 收件人: "TextureGroup/Texture"<[email protected]>; 抄送: "孙嘉琦"<[email protected]>; "Comment"<[email protected]>; 主题: Re: [TextureGroup/Texture] Compiling Texture fails on Xcode 12 due to incompatibility of PINRemoteImage library (#1914)

@MeGaPk Solution is only for cocoapods, does anybody know how can use fix this for carthage ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jiachangdangniban avatar Feb 03 '21 07:02 jiachangdangniban

@MeGaPk Solution is only for cocoapods, does anybody know how can use fix this for carthage ? try open folder Carthage > Checkouts > Texture edit Cartfile and Cartfile.lock on each lib version

GGTyrodev avatar Apr 14 '21 06:04 GGTyrodev